fixes #357: No longer show NPE on admin console after user session expired #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guusdk
force-pushed
the
357_AuthFilter-name-collision
branch
from
57ef539 to
66ef6b4
Compare
guusdk
force-pushed
the
357_AuthFilter-name-collision
branch
from
66ef6b4 to
5c5fa36
Compare
…ser session expired The NPE shown was an artifact of the page being processed without authentication in place. This should be prevented by the AuthCheckFilter. Sadly, a naming collision prevents the AuthCheckFilter to operate on the Monitoring Service admin console pages. This commit prevents the naming collision, by renaming the endpoint on which the public API for logs is exposed (from 'monitoring' to 'logs').
guusdk
force-pushed
the
357_AuthFilter-name-collision
branch
from
5c5fa36 to
394ca41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NPE shown was an artifact of the page being processed without authentication in place. This should be prevented by the AuthCheckFilter.
Sadly, a naming collision prevents the AuthCheckFilter to operate on the Monitoring Service admin console pages.
This commit prevents the naming collision, by renaming the endpoint on which the public API for logs is exposed (from 'monitoring' to 'logs').
This is not an ideal solution, as it hides a deeper problem with regards to collision of web endpoints. Alas, I think this is the best that we can do without rewriting parts of Openfire (that may affect other plugins).